atiaomar1978-hub commented on PR #25474: URL: https://github.com/apache/camel/pull/25474#issuecomment-5281571155
## Review feedback addressed _AI-generated comment on behalf of atiaomar1978-hub (Cursor Agent)_ Thanks @davsclaus for the thorough review. All findings have been addressed in commit `43b5d17`: | # | Finding | Fix | |---|---------|-----| | 1 | Phase 2 modules missing from `coverage/pom.xml` | Added `camel-alibaba-eventbridge`, `camel-alibaba-fc`, `camel-alibaba-kms`, `camel-alibaba-sms` | | 2 | `tea-openapi` in `camel-alibaba-common` | Removed SDK dep from common; moved Tea `Config` creation into FC/SMS/KMS utils (OSS/MNS/EventBridge unaffected) | | 3 | `REQUEST_ID` as exchange property | All 4 producers now set `REQUEST_ID` via `exchange.getMessage().setHeader(...)`; headers documented in `*Headers` classes | | 4 | `PrepareCatalogMojo` alphabetical order | Moved `camel-alibaba` before `camel-google-common` | | 5 | Transitive Gson in EventBridge | Added explicit `gson` dependency in `camel-alibaba-eventbridge/pom.xml` | | 6 | Unused `Base64` import in `InvokeFunctionTest` | Removed | | 7 | Import ordering in `EncryptTest` | Fixed | ### Tests All alibaba module unit tests pass: ```bash cd components/camel-alibaba && ../../mvnw test ``` Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
