atiaomar1978-hub commented on PR #25497: URL: https://github.com/apache/camel/pull/25497#issuecomment-5302936370
## Review follow-up (@davsclaus) _AI-generated on behalf of atiaomar1978-hub using Cursor._ Addressed all items from the [changes-requested review](https://github.com/apache/camel/pull/25497#pullrequestreview-4890126512) in commit `f07d3b2b`: | # | Finding | Fix | |---|---------|-----| | 1 | `AiToolAnnotations` 6th field API change | Confirmed target is **4.23.0-SNAPSHOT** (pre-release). Added **5-arg convenience constructor** defaulting `returnDirect` to `null` + test for source compatibility. | | 2 | FQCNs in `McpToolState.knownToolNames()` | Replaced `java.util.Set` / `java.util.HashSet` with imported `Set` / `HashSet`. | | 3 | Dead `release` variable in `executeRouteTool()` | Removed flag; `releaseExchange` now called unconditionally in `finally`. | | 4 | `camel-ai-tool` compile dependency justification | Added explanation to PR description (shared registry/executor, no meaningful SPI win). | | 5 | Co-authorship attribution | New commit includes `Co-authored-by: Omar Atie`. | ### Tests (local) ```bash mvn -pl components/camel-ai/camel-ai-tool,components/camel-ai/camel-openai test \ -Dtest=AiToolAnnotationsTest,OpenAIRouteToolSupportTest,OpenAIRouteToolReturnDirectTest,McpToolCallExecutorTest,OpenAIEndpointMcpToolRefreshTest ``` **27 tests, 0 failures.** Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
