mayurbm commented on PR #25553: URL: https://github.com/apache/camel/pull/25553#issuecomment-5349391168
Addressed review feedback from @atiaomar1978-hub: **Comment 1** (MailConsumer.java line 530 — catch placement): Acknowledged and agreed. The catch-before-MessagingException ordering is required and intentional. The wrapping also covers expunged messages during copy/move, not only setFlag — no code change needed. **Comment 2** (MailConsumerCommitExpungedMessageTest.java line 52 — test conventions): Applied in commit cb2b59c: - Dropped `public` from class and both test methods (now package-private) - Replaced all JUnit `assertEquals`/`assertInstanceOf`/`assertNotNull` with AssertJ `assertThat(...).isInstanceOf().hasMessage().hasCauseInstanceOf()` chains Local validation after changes: - `mvn formatter:format impsort:sort` — no changes needed (already clean) - `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0` [JDK 21 / Maven 3.9] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
