mayurbm commented on PR #25554: URL: https://github.com/apache/camel/pull/25554#issuecomment-5407854593
### CI Build Failure Fix — `NettyHttpTwoRoutesValidateBootstrapConfigurationTest` **Failure:** ``` NettyHttpTwoRoutesValidateBootstrapConfigurationTest.testTwoRoutes exepected: <java.lang.IllegalArgumentException> but was: <org.apache.camel.FailedToStartRouteException> ``` **Root cause:** Same pattern as `DefaultSupervisingRouteControllerTest` fixed in the previous commit. The `FailedToStartRouteException` wrapping introduced by this PR now also applies to `NettyHttpConsumer.doStart()` → `InternalRouteStartupManager.doStartOrResumeRouteConsumers()`. The test was asserting `assertThrows(IllegalArgumentException.class, ...)` directly, but the exception is now wrapped. **Fix:** Updated `testTwoRoutes()` to assert `FailedToStartRouteException` on the outer exception and verify the cause is `IllegalArgumentException` with the expected message — identical pattern to `DefaultSupervisingRouteControllerTest`, `MainSupervisingRouteControllerTest`, and `SpringSupervisingRouteControllerTest`. **Note:** Scanned all other `assertThrows(..., context.start())` usages across the codebase — no other tests are affected because all other cases already use `Exception.class` or `RuntimeCamelException.class` as the expected type, which are superclasses of `FailedToStartRouteException` and continue to pass. Local validation: - `mvn formatter:format impsort:sort` on `components/camel-netty-http` — no changes needed - `NettyHttpTwoRoutesValidateBootstrapConfigurationTest`: Tests run: 1, Failures: 0 - `DefaultSupervisingRouteControllerTest`: Tests run: 2, Failures: 0 - `InternalRouteStartupManagerConsumerStartTest`: Tests run: 2, Failures: 0 - `MainSupervisingRouteControllerTest`: Tests run: 3, Failures: 0 - `SpringSupervisingRouteControllerTest`: Tests run: 1, Failures: 0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
