mayurbm commented on PR #25554: URL: https://github.com/apache/camel/pull/25554#issuecomment-5419157634
Hi @gnodet, thank you for the review! Addressed both comments: **Comment 1 — AssertJ style:** Replaced all JUnit assertions (`assertNotNull`, `assertFalse`, `assertTrue`) and the try-catch pattern with `assertThatThrownBy(() -> context.start()).isInstanceOf(FailedToStartRouteException.class).hasMessageContaining(...)` per project conventions. **Comment 2 — coverage for second catch site (`routeService.start()`):** Added a third test `testRouteServiceStartNullMessageProducesFailedToStartRouteException` that exercises the second catch site by overriding `doStart()` on the consumer (instead of `start()`). This causes the exception to propagate through `BaseService.start()` → `RouteService.start()` → the second catch block in `doStartOrResumeRouteConsumers()`. Local validation: - `mvn formatter:format impsort:sort` — no changes needed - `InternalRouteStartupManagerConsumerStartTest`: Tests run: 3, Failures: 0 Both review threads resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
