gnodet commented on code in PR #25555:
URL: https://github.com/apache/camel/pull/25555#discussion_r3856882052
##########
core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java:
##########
@@ -1226,4 +1235,5 @@ public void fatalError(SAXParseException exception)
throws SAXException {
LOG.error(exception.getMessage(), exception);
}
}
+
}
Review Comment:
Nit: spurious trailing blank line added — unrelated to the PR's purpose.
##########
core/camel-xml-jaxp/src/test/java/org/apache/camel/converter/jaxp/XmlConverterPrologTest.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.converter.jaxp;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.camel.TypeConversionException;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
Review Comment:
Minor style: per project conventions, new test code should prefer AssertJ
assertions. Consider using `assertThatThrownBy(() ->
...).isInstanceOf(TypeConversionException.class).hasMessageContaining("not
valid XML")` — this would also let you verify the diagnostic message content,
which is the core value of this PR.
Currently the tests only assert the exception type but don't verify the
message includes "Payload is not valid XML" or "possible causes".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
