mayurbm commented on PR #25555: URL: https://github.com/apache/camel/pull/25555#issuecomment-5419254398
Hi @gnodet, thank you for the review! Addressed both comments: **Comment 1 — AssertJ style + message verification:** Replaced all `assertThrows` with `assertThatThrownBy(...).isInstanceOf(TypeConversionException.class).hasMessageContaining(...)`. Tests now also verify the diagnostic message contains `"not valid XML"` and `"possible causes"` — the core value of the fix. Added `assertj-core` as a test dependency in `pom.xml` (version managed by the parent). **Comment 2 — spurious trailing blank line:** Removed the trailing blank line at the end of `XmlConverter.java`. Local validation: - `mvn formatter:format impsort:sort` — no changes needed - `Tests run: 9, Failures: 0, Errors: 0, Skipped: 0` Both review threads resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
