atiaomar1978-hub commented on PR #25507: URL: https://github.com/apache/camel/pull/25507#issuecomment-5433511387
## gnodet review feedback addressed **GitHub auth:** authenticated as \`atiaomar1978-hub\` **Commit:** \`dc007256883\` — _CAMEL-23861: Remove orphan AiConfigurationProperties service file_ ### Fix (@gnodet item #1 — must fix) Removed the orphan service descriptor: \`core/camel-main/src/generated/resources/META-INF/services/org/apache/camel/configurer/org.apache.camel.main.AiConfigurationProperties\` This referenced non-existent \`AiConfigurationPropertiesConfigurer\` — a leftover from the rename to \`AiObservabilityConfigurationProperties\`. The correct descriptor (\`org.apache.camel.main.AiObservabilityConfigurationProperties\`) remains in place. Verified the build does not regenerate the orphan file. ### Other gnodet observations (not changed) - **#2 Fragile private-field reflection** — already degrades gracefully with one-time WARN in \`extractChatModelFromClient\` - **#3 Static METHOD_CACHE classloader** — low priority; acceptable for this module - **#4 String matching in mapLangChain4jProvider** — deliberate trade-off for reflective resolution without langchain4j dependency ### Tests (local) \`\`\`bash ./mvnw -pl components/camel-ai/camel-ai-observability,components/camel-ai/camel-ai-observability-api,core/camel-main,components/camel-spring-parent/camel-spring-ai/camel-spring-ai-chat -am test \`\`\` **Result:** green (~13 min) Ready for re-review. --- _Composer on behalf of atiaomar1978-hub (AI-generated)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
