atiaomar1978-hub commented on PR #25507:
URL: https://github.com/apache/camel/pull/25507#issuecomment-5398363459
Addressed the latest review feedback from @davsclaus in commits c83ec16 and
4e75e0c:
**Review fixes (c83ec16)**
1. Removed dash-style `camel.ai-observability.enabled` alias and fallback
resolution — only `camel.aiObservability.enabled` is supported now.
2. Refactored `GenAiModelResolver` to resolve LangChain4j types via Camel
`ClassResolver` (passed from all AI producers) with cached `Method` lookups.
3. Added one-time WARN in `SpringAiChatProducer` when reflection into
`ChatClient` fails.
**CI fix (4e75e0c)**
Fixed `LangChain4jEmbeddingsObservabilityTest` failure in
`camel-langchain4j-embeddings`:
- Use the model class loader with `ClassResolver` for type checks
- Call `setAccessible(true)` for non-public model implementations
- Resolve embedding model names via `defaultRequestParameters()` before
`modelName()`
**Tests run locally (all green):**
```
./mvnw -pl
components/camel-ai/camel-ai-observability-api,components/camel-ai/camel-ai-observability,components/camel-ai/camel-langchain4j-embeddings,components/camel-spring-parent/camel-spring-ai/camel-spring-ai-chat,core/camel-main
-am test \
-Dtest=GenAiModelResolverTest,LangChain4jEmbeddingsObservabilityTest,SpringAiChatObservabilityTest,AiObservabilityConfigurationPropertiesTest,GenAiObservabilityTest
```
_AI-generated comment on behalf of atiaomar1978-hub_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
