ramu11 commented on code in PR #25905:
URL: https://github.com/apache/camel/pull/25905#discussion_r3893653252


##########
components/camel-hivemq/src/main/java/org/apache/camel/component/hivemq/HiveMQConfiguration.java:
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.hivemq;
+
+import com.hivemq.client.mqtt.MqttVersion;
+import com.hivemq.client.mqtt.datatypes.MqttQos;
+import org.apache.camel.spi.Metadata;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.spi.UriParams;
+
+@UriParams
+public class HiveMQConfiguration implements Cloneable {
+
+    /**
+     * Hostname or IP address of the HiveMQ MQTT broker.
+     */
+    @UriParam(defaultValue = HiveMQConstants.DEFAULT_HOST)
+    private String host = HiveMQConstants.DEFAULT_HOST;
+
+    /**
+     * Port number of the HiveMQ MQTT broker.
+     */
+    @UriParam(defaultValue = "1883")
+    private int port = HiveMQConstants.DEFAULT_PORT;
+
+    /**
+     * Client identifier used when connecting to the HiveMQ broker.
+     */
+    @UriParam
+    private String clientId;
+
+    /**
+     * MQTT protocol version to use for the connection.
+     */
+    @UriParam(defaultValue = "MQTT_5_0")
+    private MqttVersion version = MqttVersion.MQTT_5_0;
+
+    /**
+     * Default Quality of Service (QoS) level to use for messages.
+     */
+    @UriParam(defaultValue = "AT_LEAST_ONCE")
+    private MqttQos qos = MqttQos.AT_LEAST_ONCE;
+
+    /**
+     * Whether published messages should be retained by the MQTT broker.
+     */
+    @UriParam(defaultValue = "false")
+    private boolean retained;
+
+    /**
+     * Whether to initiate a clean session upon connecting to the broker.
+     */
+    @UriParam(defaultValue = "true")
+    private boolean cleanStart = true;

Review Comment:
   Addressed. cleanStart is now explicitly passed through 
connectWith().cleanStart(...) for both producer and consumer, so the configured 
value is no longer ignored.
   
   sessionExpiryInterval is not exposed in this PR; adding persistent-session 
configuration would be a separate enhancement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to