ramu11 commented on code in PR #25905: URL: https://github.com/apache/camel/pull/25905#discussion_r3893513681
########## components/camel-hivemq/src/main/java/org/apache/camel/component/hivemq/HiveMQConsumer.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hivemq; + +import com.hivemq.client.mqtt.mqtt5.Mqtt5AsyncClient; +import com.hivemq.client.mqtt.mqtt5.message.publish.Mqtt5Publish; +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.support.DefaultConsumer; + +public class HiveMQConsumer extends DefaultConsumer { + + private final HiveMQEndpoint endpoint; + private Mqtt5AsyncClient client; + + public HiveMQConsumer(HiveMQEndpoint endpoint, Processor processor) { + super(endpoint, processor); + this.endpoint = endpoint; + } + + @Override + protected void doStart() throws Exception { + super.doStart(); + client = endpoint.createClient(); + client.connect().join(); + + client.subscribeWith() + .topicFilter(endpoint.getTopic()) + .qos(endpoint.getConfiguration().getQos()) + .callback(this::onMessage) Review Comment: Addressed both points. Message processing is dispatched from the HiveMQ callback to a Camel-managed executor and uses AsyncProcessor, preventing route processing from blocking the HiveMQ I/O thread. The current auto-acknowledgement behavior is documented, including that acknowledgement is not tied to route processing success/failure. Manual acknowledgement is documented as a limitation/follow-up. No further changes are required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
