gnodet-bot commented on code in PR #25598:
URL: https://github.com/apache/camel/pull/25598#discussion_r4010672209
##########
.github/workflows/pr-ci-scripts-validation.yml:
##########
@@ -45,3 +46,15 @@ jobs:
run: |
cd .github/actions/check-container-upgrade
python3 -m unittest discover --verbose
+
+ # collect-flakes.py declares defusedxml inline (PEP 723); uv resolves it.
+ - name: Install uv
+ uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d #
v10.0.1
+ with:
+ enable-cache: true
+
+ - name: Test the incremental build scripts
+ shell: bash
Review Comment:
⚠️ **Inconsistency: uv/Python version not pinned in the validation workflow**
`action.yaml` now correctly pins `version: "0.12.5"` and `python-version:
"3.11"` — that was the whole point of commit `cbda9e9`. But this `Install uv`
step in the validation workflow omits both, so the test runner picks up
whatever `uv` is current and whatever Python `uv` defaults to.
The PR description says _"both the uv version and the Python version it
resolves against are pinned explicitly"_ — that's true for the composite
action, but not for this workflow. A uv release or Python resolver change would
break the tests here before it breaks production, which is the inverse of what
you want.
```suggestion
- name: Install uv
uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d #
v10.0.1
with:
enable-cache: true
version: "0.12.5"
python-version: "3.11"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
