gnodet-bot commented on code in PR #25598:
URL: https://github.com/apache/camel/pull/25598#discussion_r4010765874
##########
.github/workflows/pr-ci-scripts-validation.yml:
##########
@@ -45,3 +46,15 @@ jobs:
run: |
cd .github/actions/check-container-upgrade
python3 -m unittest discover --verbose
+
+ # collect-flakes.py declares defusedxml inline (PEP 723); uv resolves it.
+ - name: Install uv
+ - name: Install uv
+ uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d #
v10.0.1
+ with:
+ enable-cache: true
+ version: "0.12.5"
+ python-version: "3.11"
+ run: |
+ cd .github/actions/incremental-build
+ uv run --with defusedxml python3 -m unittest discover --verbose
Review Comment:
⚠️ **Broken YAML: two problems that will fail the workflow**
1. **Duplicate `- name: Install uv`** (line 51 vs 52): line 51 is an empty
step with no `uses`, `run`, or `shell` — GitHub Actions rejects steps with no
executable body.
2. **`run:` on a `uses:` step**: A step cannot have both `uses:` and `run:`.
These keys are mutually exclusive in GHA — a `uses:` step delegates execution
to an action; `run:` executes a shell command. Combining them is a schema error.
The `run:` block is the test command that was meant to be a separate step.
Split into two steps:
```suggestion
# collect-flakes.py declares defusedxml inline (PEP 723); uv resolves
it.
- name: Install uv
uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d #
v10.0.1
with:
enable-cache: true
version: "0.12.5"
python-version: "3.11"
- name: Test flake collection scripts
shell: bash
run: |
cd .github/actions/incremental-build
uv run --with defusedxml python3 -m unittest discover --verbose
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
