davsclaus commented on PR #26459: URL: https://github.com/apache/camel/pull/26459#issuecomment-5678705977
Thanks for the review @oscerd — on the four notes: - **`closest()` tie-break**: fixed in 411346a8248d together with gnodet's finding. Equal-distance candidates are now tie-broken by the longer common prefix with the typed name, and a remaining tie returns no suggestion, so the result no longer depends on `Map.ofEntries` iteration order. - **Quarkus half by convention**: checked against a current camel-quarkus main — 89 of the 381 artifactIds in the table (~23%) have no `camel-quarkus-<suffix>` extension, mostly newer components (`aws2-s3-vectors`, `pgvector`, `duckdb`, `spring-ai-*`) and a few deliberately absent ones (`undertow`, `spring-*`). camel-quarkus is not a build-time dependency of camel-util so the table cannot verify it; the plain artifactId and the starter are the reliable part and the Quarkus name is right for the rest. Kept as is for now — happy to soften the wording or drop that half if you'd prefer. - **Downstream exact-message assertions**: grepped current camel-spring-boot and camel-quarkus main for every changed message text (`No endpoint could be found for`, `please check your classpath contains the needed Camel component jar`, `No language could be found for`, `Unknown expression with id`, `e.g. camel-`) — no hits. - **AssertJ in `DataFormatMissingJarHintTest`**: left as JUnit on purpose. It lives in `core/camel-core/.../processor`, where 808 of 815 tests use JUnit assertions, and CLAUDE.md asks not to introduce AssertJ as an outlier in a module that is predominantly JUnit; the AssertJ siblings are in camel-util and camel-core-languages, which have no such convention. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
