davsclaus commented on code in PR #26459: URL: https://github.com/apache/camel/pull/26459#discussion_r4015289456
########## core/camel-core/src/test/java/org/apache/camel/processor/DataFormatMissingJarHintTest.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.processor; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.builder.RouteBuilder; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; Review Comment: Keeping JUnit here on purpose. The rule in CLAUDE.md is per module, not per PR: "check the assertion style already used by the other test classes in the component/module being touched: if they are predominantly JUnit assertions, write new tests in that same JUnit style rather than introducing AssertJ as an outlier". This test lives in `core/camel-core/.../processor`, where 808 of 815 test classes use JUnit assertions, so converting it would make it the outlier. `ArtifactUtilsTest` (camel-util) and `SimpleSyntaxHintsTest` (camel-core-languages) are in different modules and follow those modules' conventions. On `DefaultCamelContextTest` "mixing with existing AssertJ": that file has no AssertJ at all — 0 `assertThat`, 55 JUnit assertions — so the new cases match it. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
