Suhail98 commented on code in PR #6832:
URL: https://github.com/apache/camel-k/pull/6832#discussion_r4053083851
##########
docs/modules/ROOT/pages/configuration/dependencies.adoc:
##########
@@ -11,7 +11,7 @@ from("imap://[email protected]")
Since the integration has a endpoint starting with the **"imap:" prefix**,
Camel K is able to **automatically add the "camel-mail" component** to the list
of required dependencies. The `seda:` endpoint belongs to `camel-core` that is
automatically added to all integrations, so Camel K will not add additional
dependencies for it. This dependency resolution mechanism is transparent to the
user, that will just see the integration running.
-Automatic resolution is also a nice feature in _dev mode_, because you are
allowed to add all components you need *without exiting the dev loop*.
+Automatic resolution is also a nice feature while you iterate on an
integration, because you are allowed to add all components you need *without
editing the list of dependencies by hand*.
Review Comment:
Agreed, removed the sentence.
##########
pkg/util/sync/file.go:
##########
@@ -1,56 +0,0 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-// Package sync provides useful tools to get notified when a file system
resource changes
-package sync
-
-import (
- "context"
-
- "github.com/fsnotify/fsnotify"
Review Comment:
Good catch — `pkg/util/sync` was the only first-party user of `fsnotify`.
`go mod tidy` moves it from the direct require block to the indirect one, since
viper still pulls it in. `go.sum` is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
