Suhail98 commented on PR #6832: URL: https://github.com/apache/camel-k/pull/6832#issuecomment-5748642141
Both lint issues fixed, and both turned out to be fallout from the removal rather than formatting noise: - **gosec G118** in `root.go` — `syncIntegration` held the only call to `RootCmdOptions.ContextCancel`, so once it was gone the cancel func from `WithCancel` was never called. The child context only existed so sync could cancel and restart the in-flight command, so I dropped it, along with `RootContext`, whose single remaining use was the `<-o.RootContext.Done()` wait point in `run`. That now waits on `o.Context`, which is the same instant: the child was only ever cancelled by its parent. Shout if you'd rather keep the fields and silence the linter instead. - **tagalign** in `run.go` — the removed `Sync` / `Dev` fields left the surrounding tags ragged. Realigned. No `make` on my machine, so I ran the pinned linter directly: `golangci-lint v2.13.2 run --config .golangci.yml`. Clean apart from 12 `mnd` reports in files listed under `mnd.ignored-files` — those paths use forward slashes, so the ignore list doesn't match on Windows. Nothing there is touched by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
