gnodet-bot commented on code in PR #26628:
URL: https://github.com/apache/camel/pull/26628#discussion_r4057202866
##########
components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConfiguration.java:
##########
@@ -114,13 +114,13 @@ public class MailConfiguration implements Cloneable {
private boolean ignoreUnsupportedCharset;
@UriParam(label = "producer,advanced,security", security = "insecure:ssl")
private boolean useJavaMailSessionPropertiesFromHeaders;
- @UriParam(label = "producer")
+ @UriParam(defaultValue = "true", label = "producer")
Review Comment:
⚠️ **Incorrect fix direction.** Commit `e027f1836524c` (CAMEL-23747)
deliberately removed `defaultValue = "true"` here and reset the field
initializer to `false` for secure-by-default. Adding it back undoes that
security hardening without any corresponding `= true` on the field — the
annotation attribute is documentation metadata only and does not affect the
runtime value.
The actual bug is in the Javadoc: the setter descriptions for all four
options still say "Defaults to true." That text should be updated to reflect
the current `false` default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
