Croway commented on PR #26628: URL: https://github.com/apache/camel/pull/26628#issuecomment-5750497227
The useHeader* defaults are correct as-is, false is correct and introduced by CAMEL-23747, and it's documented as a breaking change in the 4.21 upgrade guide. Changing defaultValue to true would make the catalog, IDE completion and the generated starter disagree with the code, and regenerating camel-spring-boot would silently flip Spring Boot users back to header-overrides-enabled. Could you revert the MailConfiguration annotation change and instead update: - the four setter javadocs (MailConfiguration.java:731,743,755,767) — "Defaults to false. Set to true to let message headers override…"; these feed the description in the JSONs - mail-component.adoc:303-306 — Default column to false; the "Effect when set to false" column now describes the default, so it needs re-heading or inverting - mail-component.adoc:308 — drop "All four default to true so existing behaviour is preserved" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
