harshilv17 commented on PR #6834:
URL: https://github.com/apache/camel-k/pull/6834#issuecomment-5751385107
Thanks @squakez — taking you up on continuing here, so this PR now closes
#6836 as well.
Pushed `6ad0fe3`, which renames the ten `SyntheticKit` identifiers that were
left in the trait tests. While doing it I found they are not all the same case,
so a single `NonManagedBuild` rename would have replaced one misleading name
with another:
- `trait_types_test.go` — the two `DetermineControllerStrategy` tests
genuinely do use `createNonManagedBuildTestEnvironment`, so those became
`...NonManagedBuild{Default,ForceKnative}`.
- `knative_test.go`, `kamelets_test.go`, `health_test.go` — these set
`CamelCatalog = nil`, and the knative helper additionally omits the sources
that `NewFakeEnvironment` sets. That is a Kit with no catalog attached rather
than a non managed build, so they became `...WithoutCatalog...`.
Identifiers and one comment only, nothing about the setup or the assertions
changed: 11 lines across 4 files. `grep -rn SyntheticKit pkg/` is empty now,
and `go build ./...`, `go vet ./pkg/trait/` and the whole `pkg/trait` package
pass, with all seven renamed tests running under their new names.
The 12 workflows are still gated on approval whenever someone has a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
