harshilv17 commented on PR #6834:
URL: https://github.com/apache/camel-k/pull/6834#issuecomment-5751575927
@squakez taking you up on continuing here, so this now closes #6836 as well.
Head is `198d3293`. Full detail is in the description; the short version:
- **Synthetic Kits are gone.** All 8 stale `SyntheticKit` test identifiers
renamed for what they actually assert — `...NonManagedBuild...` where the env
really is a non managed build, `...WithoutCatalog...` / `...NoSources...`
elsewhere. `grep -rn SyntheticKit pkg/` is empty.
- **One thing I had stated too strongly.** `IsExternal() || IsSynthetic()` →
`IsExternal()` is a reduction, not an equivalence — it differs for a Kit
labelled `kit.type: synthetic`. I had said nothing ever wrote that label; true
of `main`, but `pkg/trait/container.go` wrote it in **2.4.0** only (`a5c2ce7`
until `515c762`). Such a Kit now loses the deprecation condition, gets a
digest, flips to `Initialization`, and `initialize.go` returns it to `Ready` on
its `Spec.Image != ""` path — one status write, no loop. Consistent with
`e51a99e`, but your call, so it is written up under **Upgrade behaviour**
rather than glossed over.
- **Worth knowing:** `pkg/controller/integrationkit` has no test files, so
those three branches are review-covered only, before and after.
`go build ./...`, `go vet ./...`, `gofmt` and the `pkg/trait` /
`pkg/apis/...` suites are clean. Remaining failures (`pkg/builder`,
`pkg/controller/integrationplatform`, `pkg/kamelet/repository`,
`pkg/util/{camel,jvm,maven}`) are byte-identical to a clean `origin/main`
worktree here — missing `mvn`, plus network for two git clone tests.
The 12 workflows are gated on approval whenever someone has a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
