davsclaus commented on code in PR #26657:
URL: https://github.com/apache/camel/pull/26657#discussion_r4060115444
##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultErrorRegistry.java:
##########
@@ -196,6 +196,12 @@ private void capture(Exchange exchange, boolean handled) {
} else {
for (BacklogErrorEventMessage e : entries) {
if (exchangeId.equals(e.getExchangeId())) {
+ // the copy's entry stays (it names the node), but the
original reporting the failure as
+ // handled (a circuit breaker's fallback, a doCatch around
a multicast) means the exchange
+ // recovered: the entry is an error that was handled, not
an error (CAMEL-24863)
+ if (handled && !e.isHandled() && e instanceof
DefaultBacklogErrorEventMessage impl) {
Review Comment:
Done in 8af514294e92: `markHandled()` on `BacklogErrorEventMessage` (`@since
4.23`), named for what it means rather than a setter, since the only legitimate
transition is not-handled to handled after the fact; the registry calls it and
the cast is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
