gnodet-bot commented on code in PR #26657: URL: https://github.com/apache/camel/pull/26657#discussion_r4060854836
########## components/camel-resilience4j/src/test/java/org/apache/camel/component/resilience4j/ResilienceFallbackErrorRegistryTest.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.resilience4j; + +import java.util.Collection; + +import org.apache.camel.CamelContext; +import org.apache.camel.RoutesBuilder; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.spi.BacklogErrorEventMessage; +import org.apache.camel.test.junit6.CamelTestSupport; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * CAMEL-24863: a failure the circuit breaker's fallback recovered from is an error that was handled, in the error + * registry (camel get errors, the dev console): the entry keeps the node that failed and says handled. + */ +public class ResilienceFallbackErrorRegistryTest extends CamelTestSupport { + + @Override + protected CamelContext createCamelContext() throws Exception { + CamelContext context = super.createCamelContext(); + context.getErrorRegistry().setEnabled(true); + return context; + } + + @Test + public void testFallbackRecordsTheFailureAsHandled() throws Exception { + MockEndpoint mock = getMockEndpoint("mock:result"); + mock.expectedBodiesReceived("Fallback response", "Fallback response"); + + template.sendBody("direct:start", "Hello World"); + template.sendBody("direct:start", "Hello World"); + + MockEndpoint.assertIsSatisfied(context); + + Collection<BacklogErrorEventMessage> entries = context.getErrorRegistry().browse(); + assertEquals(2, entries.size(), "one entry per failed call, the copy's and the original's are the same one"); + for (BacklogErrorEventMessage e : entries) { + assertTrue(e.isHandled(), "the fallback handled the failure: " + e); + assertEquals("java.lang.IllegalStateException", e.getExceptionType()); + } + } + Review Comment: 💬 **Misleading assertion message** The two sends produce two distinct exchange IDs → two separate registry entries: the assertion count (`2`) is correct, but the message `"the copy's and the original's are the same one"` reads as if both entries belong to a single exchange, which is wrong for a multi-call scenario. What it likely means to convey is: _for each call, the copy's `ExchangeFailedEvent` and the original's `ExchangeFailureHandledEvent` merge into the same single registry slot_ (the copy's entry is marked handled in place rather than a second entry being added). Suggest clarifying: ```suggestion assertEquals(2, entries.size(), "one registry entry per call: the copy's ExchangeFailedEvent and the original's ExchangeFailureHandledEvent merge into the same slot"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
