Copilot commented on code in PR #26906:
URL: https://github.com/apache/camel/pull/26906#discussion_r4106827618
##########
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java:
##########
@@ -539,7 +539,9 @@ private boolean updateHeader(
newLines.add(":shortname: " + shortName);
if (model instanceof ArtifactModel<?>) {
- newLines.add(":artifactid: " + ((ArtifactModel<?>)
model).getArtifactId());
+ ArtifactModel<?> artifactModel = (ArtifactModel<?>) model;
+ newLines.add(":groupid: " + artifactModel.getGroupId());
+ newLines.add(":artifactid: " + artifactModel.getArtifactId());
Review Comment:
Please regenerate and commit the catalog copies as well.
`PrepareCatalogMojo` copies `src/main/docs` into
`catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs`,
and `DefaultCamelCatalog.asciiDoc()` serves those resources; for example, the
catalog's `xslt-component.adoc` still has `:artifactid:` immediately after
`:shortname:` with no `:groupid:`. Without those mirrored updates, the shipped
catalog/API output remains incomplete even though the source documentation has
the new attribute.
##########
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java:
##########
@@ -539,7 +539,9 @@ private boolean updateHeader(
newLines.add(":shortname: " + shortName);
if (model instanceof ArtifactModel<?>) {
- newLines.add(":artifactid: " + ((ArtifactModel<?>)
model).getArtifactId());
+ ArtifactModel<?> artifactModel = (ArtifactModel<?>) model;
+ newLines.add(":groupid: " + artifactModel.getGroupId());
Review Comment:
AI-generated review comment (on behalf of the human operator): This
generator now emits the attribute, but the generated source set is incomplete:
`components/camel-ftp/src/main/docs/ftp-component.adoc` still has
`:artifactid:` immediately after `:shortname:` even though its `ftp.json`
contains `groupId: org.apache.camel`. Please rerun
`camel-package:update-readme` for the full reactor and commit all resulting
source documentation changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
