gnodet commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-5872296166
@apupier Thanks for the review. **Documentation (registerMbeans):** Replied inline — `registerMbeans=true` is not required. We call `getHikariPoolMXBean()` directly via reflection on the DataSource, not through JMX. See [the source](https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/HikariDataSource.java#L285). **Tests closer to real use case:** The latest commit (`d711425`) already includes a real HikariCP+h2 integration test (`DataSourceHelperHikariIntegrationTest`) that exercises the actual reflection path against a real HikariDataSource — both the started-pool and not-started-pool paths. This was requested and approved by @davsclaus. The test verifies that eviction actually replaces the physical connection (via `unwrap()` comparison), not just `assertDoesNotThrow`. **Camel Quarkus native reflection registration:** Good point — I'll open a follow-up ticket on camel-quarkus. The classes used by reflection are `HikariDataSource.getHikariPoolMXBean()` and `HikariPoolMXBean.softEvictConnections()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
