gnodet commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-5854745037
Both test points addressed in d711425: 1. **Not-started pool**: switched to no-arg `new HikariDataSource()` + setters (lazy init). Added explicit `assertNull(ds.getHikariPoolMXBean())` to prove the MXBean is truly null before testing eviction. 2. **Stronger assertions on started pool**: replaced `assertDoesNotThrow` with `assertNotSame(physicalBefore, physicalAfter)` — unwraps the physical `Connection` before and after eviction, using `maxPoolSize=1` to force the same slot. Proves the pool actually replaced the evicted connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
