ramu11 commented on PR #27314:
URL: https://github.com/apache/camel/pull/27314#issuecomment-6014885637
> Finding Status
> 1 **Generated files stale** — catalog `hibernate.json` and
`HibernateEndpointBuilderFactory` still list removed `CamelHibernateSession`
header, `statelessOperation` as `string` (not enum), and lack `consumeDelete`
❌ NOT addressed — please regenerate catalog then endpointdsl
> 2 **Docs** — `hibernate-component.adoc` should mention
`consumeDelete=true` default, session reuse scope/limits ❌ Not clearly
addressed
> 3 **Co-authored-by trailer** for AI assistance ❌ Not added
> 4 **H2-backed route-level test** for skipLocked self-deadlock ❌ Not
added
Thanks for the detailed review. I went through the findings again against
the current branch:
1. **Generated files — addressed**
- The catalog and Endpoint DSL were regenerated in commit `21604472195f`
(`Regen`).
- The stale `CamelHibernateSession` header is removed.
- `statelessOperation` is represented with the generated enum values
(`INSERT`, `UPSERT`).
- `consumeDelete` is present in the generated catalog and Endpoint DSL.
2. **Documentation — addressed**
- The documentation now describes `consumeDelete=true` as the default and
explains how to disable it.
- It also documents consumer → producer session reuse, including its
scope and limitations.
- The session/filter compatibility and cases where a separate session is
required are documented as well.
3. Co-authored-by trailer
Not applicable in this case. I am the sole author of the changes and
personally reviewed and verified the implementation and tests. I have not added
a Co-authored-by trailer.
4. **H2-backed SKIP_LOCKED regression coverage — addressed**
- `shouldSkipLockedRowsWithH2()` exercises `skipLocked=true` against a
real H2-backed `SessionFactory` while another Hibernate session holds a
`PESSIMISTIC_WRITE` lock, and verifies that the consumer skips the locked row.
- `shouldReuseConsumerSessionInRouteWithSkipLocked()` additionally covers
the consumer → producer route/session-reuse scenario with `skipLocked`.
- So this is covered by the current test suite rather than only by
Mockito-based API verification.
The generated files, documentation, and H2 `skipLocked` coverage are
therefore addressed in the current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
