gnodet-bot commented on code in PR #27314: URL: https://github.com/apache/camel/pull/27314#discussion_r4186068015
########## components/camel-hibernate/src/main/java/org/apache/camel/component/hibernate/HibernateProducer.java: ########## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hibernate; + +import java.util.Map; +import java.util.stream.Stream; + +import org.apache.camel.Exchange; +import org.apache.camel.support.DefaultProducer; +import org.apache.camel.support.SynchronizationAdapter; +import org.hibernate.KeyType; +import org.hibernate.Session; +import org.hibernate.StatelessSession; +import org.hibernate.Transaction; +import org.hibernate.query.MutationQuery; +import org.hibernate.query.SelectionQuery; + +public class HibernateProducer extends DefaultProducer { + + private final HibernateEndpoint endpoint; + + public HibernateProducer(HibernateEndpoint endpoint) { + super(endpoint); + this.endpoint = endpoint; + } + + @Override + public void process(Exchange exchange) throws Exception { + if (endpoint.getStatelessOperation() != null) { + processStateless(exchange); + return; + } + + HibernateSessionContext sessionContext = exchange.getExchangeExtension() + .getSafeCopyProperty(HibernateConstants.HIBERNATE_SESSION_CONTEXT, HibernateSessionContext.class); + + Session session = sessionContext == null + ? null + : sessionContext.getSession(endpoint.getSessionFactory(), endpoint.getTenantIdentifier()); + + boolean sessionOwned = session == null; + + if (sessionOwned) { + session = endpoint.getTenantIdentifier() == null + ? endpoint.getSessionFactory().openSession() + : endpoint.getSessionFactory().withOptions() + .tenantIdentifier(endpoint.getTenantIdentifier()) + .openSession(); + } + + final Session activeSession = session; + final Transaction transaction = sessionOwned + ? activeSession.beginTransaction() + : activeSession.getTransaction(); + + try { + if (sessionOwned && endpoint.getFilters() != null) { + endpoint.getFilters().forEach((filterName, parameters) -> { + var filter = activeSession.enableFilter(filterName); + if (parameters != null) { + parameters.forEach(filter::setParameter); + } + }); + } + + @SuppressWarnings("unchecked") + Map<String, Object> parameters = exchange.getMessage().getHeader( + HibernateConstants.HIBERNATE_PARAMETERS, Map.class); + + if (endpoint.getNaturalIdParameters() != null) { + Object entity = activeSession.find( + endpoint.getEntityType(), + endpoint.getNaturalIdParameters(), + KeyType.NATURAL); + + exchange.getMessage().setBody(entity); + + if (sessionOwned) { + transaction.commit(); + activeSession.close(); + } + } else if (endpoint.getSelectionQuery() != null) { + SelectionQuery<?> query = activeSession.createSelectionQuery( + endpoint.getSelectionQuery(), endpoint.getEntityType()); + + if (sessionOwned) { + activeSession.setDefaultReadOnly(endpoint.isReadOnly()); + } + query.setReadOnly(endpoint.isReadOnly()); + + if (parameters != null) { + parameters.forEach(query::setParameter); + } + + if (endpoint.isStreaming()) { + if (sessionOwned) { + exchange.getExchangeExtension().addOnCompletion(new SynchronizationAdapter() { + @Override + public void onComplete(Exchange exchange) { + closeStreamingSession(activeSession, transaction, false); + } + + @Override + public void onFailure(Exchange exchange) { + closeStreamingSession(activeSession, transaction, true); + } + }); + } + + Stream<?> stream = query.getResultStream(); + + if (sessionOwned) { + exchange.getMessage().setBody(stream.onClose( + () -> closeStreamingSession(activeSession, transaction, false))); Review Comment: ⚠️ **Streaming double-close bug still present.** Both the `SynchronizationAdapter` (lines 111–121) and `stream.onClose()` (line 127–128) call `closeStreamingSession()`. When both fire — which happens on normal completion — the second `session.close()` throws `IllegalStateException: Session/EntityManager is closed`. Fix: guard with an `AtomicBoolean`: ```suggestion if (sessionOwned) { java.util.concurrent.atomic.AtomicBoolean closed = new java.util.concurrent.atomic.AtomicBoolean(); exchange.getExchangeExtension().addOnCompletion(new SynchronizationAdapter() { @Override public void onComplete(Exchange exchange) { if (closed.compareAndSet(false, true)) { closeStreamingSession(activeSession, transaction, false); } } @Override public void onFailure(Exchange exchange) { if (closed.compareAndSet(false, true)) { closeStreamingSession(activeSession, transaction, true); } } }); Stream<?> stream = query.getResultStream(); if (sessionOwned) { exchange.getMessage().setBody(stream.onClose( () -> { if (closed.compareAndSet(false, true)) closeStreamingSession(activeSession, transaction, false); })); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
