mionker commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-6044869413
> Thanks for the update @mionker, and for the note about `JmsExclusiveTestSupport.reconnect()`. That looks worth its own JIRA. > > The PR branch only got a merge from `main` since my last review ([bf1c060](https://github.com/apache/camel/commit/bf1c060b269618360d3a3eef28880050e4efe6e1)). The commit with "a lot of updates and additions" you mentioned isn't on `mionker:sjms-batch` yet: the batch classes, `SjmsEndpoint`, `SjmsConstants`, the docs and the tests are the same as in [4f12a64](https://github.com/apache/camel/commit/4f12a64dadd59f85d3f49c819ae6edb3e1492ba9). Could you check that it was pushed to the `sjms-batch` branch of your fork? Once it's there, I'll go through the list again. > > So the points from my previous review are all still open: the rollback-only batch being committed, the NPE when `aggregate()` throws, releasing the batch exchange, the WARN on a normal stop, the drain on connection loss, the `ExceptionHandler`/poison-batch loop, validation, metadata/descriptions, docs, tests, the `Co-authored-by` trailer and the PR description. > > With [CAMEL-25312](https://issues.apache.org/jira/browse/CAMEL-25312) (sjms suspend/resume/restart) now merged from `main`, tests for a batching route after a route stop/start and with suspend/resume would cover the "route stop/start" item from my earlier list. One new issue that the restart support makes reachable is inline. > > _Claude Code on behalf of davsclaus. This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._ I work on this ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
