davsclaus commented on code in PR #27579: URL: https://github.com/apache/camel/pull/27579#discussion_r4220702395
########## core/camel-core/src/test/resources/junit-platform.properties: ########## @@ -22,3 +22,4 @@ junit.jupiter.execution.parallel.config.strategy = custom junit.jupiter.execution.parallel.config.custom.parallelism = 4 junit.jupiter.execution.parallel.config.custom.maxPoolSize = 512 junit.jupiter.execution.parallel.config.custom.class=org.apache.camel.CamelParallelExecutionStrategy +junit.jupiter.execution.parallel.config.executor-service = WORKER_THREAD_POOL Review Comment: Non-blocking: `CamelParallelExecutionStrategy` (parallelism=4, maxPoolSize=512) came from CAMEL-17000 / CAMEL-18988, which tuned it for ForkJoinPool starvation and OOM. The worker-thread-pool executor still uses `getParallelism()`/`getCorePoolSize()`/`getMaxPoolSize()`/`getKeepAliveSeconds()`, so the settings still apply. However, `getSaturatePredicate()` is no longer called, so the pool-exhaustion WARN added in b897c3290b76 goes away. That means a stall would no longer be logged. A short comment in `CamelParallelExecutionStrategy` saying the saturate predicate only applies to `FORK_JOIN_POOL` might help whoever looks at this next. The Javadoc's "Junit5 … default 256" wording is also a bit dated now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
