gnodet-bot commented on code in PR #27690:
URL: https://github.com/apache/camel/pull/27690#discussion_r4243913197
##########
components/camel-knative/camel-knative-http/src/main/java/org/apache/camel/component/knative/http/KnativeHttpProducer.java:
##########
@@ -102,9 +105,26 @@ public boolean process(Exchange exchange, AsyncCallback
callback) {
headers.add(HttpHeaders.CONTENT_TYPE, contentType);
}
Review Comment:
💡 **Nit:** `exchange.getContext().getTypeConverter()` is fetched on every
`process()` call. It's a cheap accessor, so this is not a performance concern,
but initialising `tc` as a field in `doStart()` (as `KnativeHttpConsumer`
already does) would be marginally cleaner and consistent with the sibling class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
