allthingssecurity commented on PR #27690:
URL: https://github.com/apache/camel/pull/27690#issuecomment-6121242586
Thanks for the decision. State of the four points on the current head
0b2030e4d83f:
- Comparison with camel-http: the sentence is not in the upgrade guide, and
the message of the first commit no longer
says that camel-http sends one header per value (it now says: one header
line per value, as camel-netty-http and
camel-undertow do). For that the branch was force-pushed with the commit
messages rewritten only: 08bd21c08373 ->
0b2030e4d83f, first commit 4b0f9b5530b1 -> b0b8299dbc6c, `git diff`
between the old and the new head is empty.
- Upgrade-guide note: in `camel-4x-upgrade-guide-4_24.adoc` under `==
Upgrading Camel 4.23 to 4.24`, nothing in the
4_23 guide; the file is created with the header of the 4_23 guide and
added to `camel-4x-upgrade-guide.adoc`.
- Only a `Collection` or an `Object[]` is split (`instanceof Collection` /
`instanceof Object[]`); every other
value, also another `Iterable` such as a Vert.x `JsonObject` or
`JsonArray`, is one header.
- The gate and the per-value filter are in one helper,
`HttpUtil.applyHeaderValue` in camel-support. #27689 adds the
same `HttpUtil.java` and `HttpUtilTest.java` byte for byte, so either PR
can be merged first and CAMEL-25563 can
reuse the helper.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]