gnodet-bot commented on PR #27686:
URL: https://github.com/apache/camel/pull/27686#issuecomment-6141954806
**Correction to my previous review — `wrapRawIfNeeded`:**
I stated that `wrapRawIfNeeded` still uses `RAW()` — that was wrong. The
commit does correctly switch to `RAW{…}` syntax, which addresses the previous
`RAW(…)` / `)` boundary issue.
However, the `RAW{…}` form introduces a symmetric problem: `URIScanner` also
uses `}` as the close token. If a value contains `}` in addition to another
URI-sensitive character (e.g., `p}ss&word`), `wrapRawIfNeeded` wraps it as
`RAW{p}ss&word}` — the first `}` closes the token early, corrupting the URI.
The fix should also check `value.contains("}")` before choosing `RAW{…}`, or
fall back to `RAW(…)` when the value has no `)`.
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
