davsclaus commented on code in PR #27791: URL: https://github.com/apache/camel/pull/27791#discussion_r4268704628
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -13,6 +13,42 @@ See the xref:camel-upgrade-recipes-tool.adoc[documentation] page for details. == Upgrading Camel 4.23 to 4.24 +=== camel-semantic - explicit experts + +Every evaluation in the preview semantic API now requires an explicit `expert` registry bean name. +Move block-level `expert` values onto each evaluation in YAML and XML; in Java, move `.expert(...)` +from `SemanticEvaluationsBuilder` to each `SemanticEvaluationBuilder`. + +The `camel.language.semantic.default-expert` and `camel.language.semantic.adapter` options, +`SemanticLanguage.setDefaultExpert` / `setAdapter`, automatic selection of a sole expert, and +`META-INF/services/org/apache/camel/semantic-adapter` discovery are removed. Register an expert +bean explicitly, including its initialization and destruction methods where needed, and reference +it from each evaluation. Expert references accept property placeholders, but do not fall back to +class loading. The default state selector is unchanged. + +The semantic metadata response no longer includes `defaultExpert`, `defaultError` or +`defaultErrorCode`. Operation inspection and completion require an explicit expert reference. + +=== camel-semantic - evaluation-only auditing + +The preview semantic audit API no longer records route actions. `SemanticAuditDecision`, +`SemanticAudit.get(context).decision(...)` and `SemanticObserver.decision(...)` have been removed. +Remove the corresponding decision beans and processor calls from routes. Evaluation auditing is +automatic under the existing audit configuration; normal application routing remains unchanged. +Previously persisted version-1 decision records remain readable and exportable as legacy data. +Semantic audit browsing no longer accepts route-action, namespace or application-correlation filters. +The console's `target` filter is also removed. Event-ID detail responses no longer expand a decision's Review Comment: New evaluation records also no longer carry `target`, because it duplicated `definition`. Readers that still look for it now find nothing, so it is worth saying here: ```suggestion New evaluation records no longer carry `target`; use `definition`, which always held the same value. The console's `target` filter is also removed. Event-ID detail responses no longer expand a decision's ``` ########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -13,6 +13,39 @@ See the xref:camel-upgrade-recipes-tool.adoc[documentation] page for details. == Upgrading Camel 4.23 to 4.24 +=== camel-semantic - explicit experts Review Comment: Dropping this request: the semantic language is Preview and new, so keeping the explicit-expert change in this PR is fine. Resolving. _Claude Code on behalf of @davsclaus._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
