luigidemasi commented on PR #27791:
URL: https://github.com/apache/camel/pull/27791#issuecomment-6167574379

   @davsclaus @gnodet, pushed e2406d2ff709, retaining the four-commit 
structure. The remaining inline requests have individual replies; the earlier 
exchange-event, restart, validator and audit fast-path fixes remain in place. I 
also updated the resolved sampler thread because the final monitoring design 
supersedes my earlier history-interval answer.
   
   For the review-level questions in [Claus's 
follow-up](https://github.com/apache/camel/pull/27791#pullrequestreview-5515404998)
 and [gnodet-bot's 
review](https://github.com/apache/camel/pull/27791#pullrequestreview-5515279532):
   
   - **Monitoring-store SPI:** removed, along with recovery, sampled history, 
comparisons/signals and example audit-event references. Camel supplies current 
measurements and collection health; external monitoring owns history, 
retention, detection, alerting and correlation. Immutable snapshots are 
current-value read objects only. 
[CAMEL-25648](https://issues.apache.org/jira/browse/CAMEL-25648) now tracks 
optional Micrometer instrumentation/Prometheus export. Audit persistence is 
separate and remains supported. Audit queries now support `[since, until)`, 
definition, operation and typed results for investigating a measured interval 
without event-ID metric labels.
   - **JMX documentation:** the [language 
guide](https://github.com/apache/camel/blob/e2406d2ff70967d7d0e8f77eb9978b895f370e80/components/camel-ai/camel-semantic/src/main/docs/semantic-language.adoc#L1466)
 documents `type=semantic`, logical names `all` and `Source(<registry-name>)`, 
the quoted object-name pattern, read-only JSON `Snapshot` attribute, 
shared-cache reads and shutdown removal. I kept this new-feature documentation 
there because the repository's upgrade-guide convention limits that guide to 
migrations. The upgrade guide now includes the missing `target` to `definition` 
migration, in addition to the removed `evidence` expansion.
   
   The PR description has the revised scope and validation details: 417 
semantic tests plus the final 15-test monitoring run, 118 CLI tests, 5 
connector tests, 5 Main tests, and the full 2,096-test TUI suite (one skip), 
all without failures. Formatter/import and exact-tree Antora checks passed. 
Full-reactor and external integration suites were not run; hosted checks for 
the new head must complete separately.
   
   _Codex (AI-generated) on behalf of @luigidemasi._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to