davsclaus commented on code in PR #27813:
URL: https://github.com/apache/camel/pull/27813#discussion_r4269042610
##########
components/camel-mail/src/main/docs/mail-component.adoc:
##########
@@ -284,7 +298,7 @@ pre-configured settings.
Map<String, Object> headers = new HashMap<String, Object>();
headers.put("to", "[email protected]");
-template.sendBodyAndHeaders("smtp://admin@[email protected]",
"Hello World", headers);
+template.sendBodyAndHeaders("smtp://admin@[email protected]&useHeaderRecipients=true",
"Hello World", headers);
----
==== Opting out of header overrides (trust-boundary hardening)
Review Comment:
This heading and the paragraph under it were written when the headers won by
default. Now the four options default to `false`, so they opt in to header
overrides rather than lock the endpoint. The example under the table sets
`useHeaderRecipients=false&useHeaderFrom=false&useHeaderReplyTo=false`, which
is the default and has no effect. Could you reword this section to match the
table (for example "Letting message headers override the endpoint
configuration"), or open a follow-up for it?
##########
components/camel-mail/src/main/docs/mail-component.adoc:
##########
@@ -235,11 +237,16 @@ YAML::
constant: "some subject"
Review Comment:
Nit, since this block is being edited anyway: the docs use the canonical
YAML form, with the `expression:` wrapper.
```suggestion
expression:
constant:
expression: "some subject"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
