davsclaus commented on code in PR #27822:
URL: https://github.com/apache/camel/pull/27822#discussion_r4269534865
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportQuarkus.java:
##########
@@ -332,8 +332,11 @@ protected String applicationPropertyLine(String key,
String value) {
// skip "camel.server." or "camel.management." as this is for
camel-main only
return null;
}
- // quarkus use dash cased properties and lets turn camel into dash as
well (skip hawtio)
- boolean dash = key.startsWith("camel.") || (key.startsWith("quarkus.")
&& !key.startsWith("quarkus.hawtio."));
+ // camel.* keys are written dash-cased, because Camel's property
binding turns the dashes back at runtime.
+ // quarkus.* keys are written as given: Quarkus accepts both camelCase
and kebab-case for its own option
Review Comment:
I could not confirm that Quarkus accepts camelCase for its own option names.
SmallRye Config's `PropertyName.equals` matches names character by character,
so `quarkus.http.rootPath` and `quarkus.http.root-path` are different keys.
Today the export dashes such a key and it works. With this change it is written
as given and would likely be ignored. #27790 keeps that case working by dashing
only segments that look like option names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
