etzel-mes opened a new pull request, #27908: URL: https://github.com/apache/camel/pull/27908
# Description [CAMEL-25626](https://issues.apache.org/jira/browse/CAMEL-25626). With the default `omitNullValues=true`, the `milo-client` consumer dropped every data change whose value was null, regardless of its status code. OPC UA Part 4 requires a server to send a null value together with a Bad status, so the null value is the carrier of the quality: a sensor failure, a removed node or a monitored item that could not be created (#27780, #27906) never reached the route unless `omitNullValues=false` was set. Why this matters in automation: a route that feeds a historian, an MES, a UNS topic or an alarm evaluates the last value it received. When the quality of a tag goes Bad and the route never hears about it, the stale value keeps being treated as current, and the plant acts on a number that nobody is measuring any more. Quality propagation is the first thing an OT integration is expected to get right; the component should deliver it by default. The change: - `omitNullValues` now omits only a data change whose value is null and whose status is Good, which is the initial value at startup that the option was introduced for (CAMEL-18144). A data change with a Bad or Uncertain status is always delivered; the body is the `DataValue` as before, the route reads the status code from it and `CamelMiloNodeId` names the node. - No new option. The condition lives in one small predicate in `MiloClientConsumer`. - Test `MonitorNodesTest#notGoodStatusWithNullValueIsDeliveredByDefault` (default option): a Good null is omitted, an Uncertain null and a Bad status are delivered, a later Good write still arrives. Fails without the fix (2 expected, 0 received). `omitNullValues=false` is no longer needed in the existing tests and was removed. - Endpoint javadoc, generated JSON, catalog copies, endpoint DSL, component docs and a 4.24 upgrade-guide note. Note on generated files: the catalog JSON and the endpoint DSL javadoc were updated by hand because their generators need `camel-allcomponents` 4.24.0-SNAPSHOT, which did not resolve locally; if the regen check differs, please let the bot overwrite them. # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. _Claude Code on behalf of etzel-mes_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
