gnodet-bot commented on code in PR #27908:
URL: https://github.com/apache/camel/pull/27908#discussion_r4285479274
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MiloClientConsumer.java:
##########
@@ -131,6 +131,15 @@ private void handleValueUpdate(final String node, final
DataValue value) {
}
}
+ /**
+ * A null value with a Good status is the initial value at startup, which
omitNullValues hides. A null value with a
+ * Bad or Uncertain status carries the quality of the node and is
delivered.
Review Comment:
💡 **Minor nit (non-blocking):** The `value == null` arm is dead code for the
same reason the checks removed in this commit were: under Milo's `@NullMarked`,
the `DataValueListener` callback delivers non-null `DataValue`, and the
internal `PendingValue` path constructs `new DataValue(status)` explicitly.
Keeping it as defensive programming is consistent with the `mapToMessage` guard
and is harmless — but a one-line comment like `// defensive — DataValue is
@NullMarked non-null in Milo's callback` would prevent this question from being
raised again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
