oscerd commented on code in PR #28105:
URL: https://github.com/apache/camel/pull/28105#discussion_r4313367763
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/lifecycle/AwsSecretsManagerKeyLifecycleManager.java:
##########
@@ -367,12 +367,17 @@ public KeyMetadata getKeyMetadata(String keyId) throws
Exception {
}
@Override
+ /**
+ * Writes the metadata secret only.
+ * <p/>
+ * Re-storing the key pair here would create a new version of the private
key secret on every status change, and
+ * would make revoking a key whose private secret is already gone
impossible - which is exactly when revoking
+ * matters.
+ */
Review Comment:
Fixed in 4975e1a — the block now sits above `@Override`. You are right that
it was not being picked up: a doc comment has to precede the whole declaration,
annotations included, so javadoc was falling back to the inherited interface
text and the explanation of why this implementation writes metadata only was
invisible. My edit introduced the misplacement.
_Claude Code on behalf of @oscerd_
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/lifecycle/AzureKeyVaultKeyLifecycleManager.java:
##########
@@ -294,12 +294,16 @@ public KeyMetadata getKeyMetadata(String keyId) throws
Exception {
}
@Override
+ /**
+ * Writes the metadata secret only.
+ * <p/>
+ * Re-storing the key pair here would create a new version of the private
key secret on every status change, and
+ * would make revoking a key whose private secret is already gone
impossible - which is exactly when revoking
+ * matters.
+ */
Review Comment:
Fixed in 4975e1a — the block now sits above `@Override`. You are right that
it was not being picked up: a doc comment has to precede the whole declaration,
annotations included, so javadoc was falling back to the inherited interface
text and the explanation of why this implementation writes metadata only was
invisible. My edit introduced the misplacement.
_Claude Code on behalf of @oscerd_
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/lifecycle/HashicorpVaultKeyLifecycleManager.java:
##########
@@ -407,12 +407,25 @@ public KeyMetadata getKeyMetadata(String keyId) throws
Exception {
}
@Override
+ /**
+ * Writes the metadata entry only.
+ * <p/>
+ * Re-storing the key pair here would create a new version of the private
key entry on every status change - with
+ * the default {@code max_versions = 10} of a KV v2 mount, ten metadata
edits purge every historical version of the
+ * private key. It would also make revoking a key whose private entry is
already gone impossible, which is exactly
+ * when revoking matters.
+ */
Review Comment:
Fixed in 4975e1a — the block now sits above `@Override`. You are right that
it was not being picked up: a doc comment has to precede the whole declaration,
annotations included, so javadoc was falling back to the inherited interface
text and the explanation of why this implementation writes metadata only was
invisible. My edit introduced the misplacement.
_Claude Code on behalf of @oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
