oscerd commented on PR #28104:
URL: https://github.com/apache/camel/pull/28104#issuecomment-6290291131
Rebased onto `main` and pushed one more commit.
- **Rebase.** The only conflict was the 4.24 upgrade guide, where several
camel-pqc PRs had added their note at the same spot. This note now sits before
the `camel-jbang - finding integrations by name or PID` section, at a different
place from the other open camel-pqc PRs, so they stop conflicting with each
other. The regenerated `pqc.json` and `PQCEndpointBuilderFactory` came through
unchanged.
- **Review feedback.** The commit "CAMEL-25805: Address review feedback -
assert where the accepted override fails rather than the absence of a wording"
replaces the `assertFalse(message.contains("holds no"))` in
`anOverrideToAnOperationNeedingNoKeyMaterialIsAllowed`. Checking where an
accepted `getKeyState` override of this endpoint actually ends up:
`checkOperationIsUsable` lets it through, and `statefulGetKeyState` then
rejects the non-stateful ML-DSA key with `IllegalArgumentException("getKeyState
is only supported for stateful signature schemes ...")` - before any
`KeyLifecycleManager` lookup, which the old comment assumed. The test now
asserts that exception and message, so a rejection of the override itself, with
any wording, fails it.
Verification: camel-pqc on JDK 21 (`mvn clean install`) and JDK 25 (`mvn
test`: 278 tests, 0 failures); full reactor `mvn clean install -DskipTests
-DskipITs` `BUILD SUCCESS`, no regenerated-file drift.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
