gnodet-bot commented on code in PR #28195:
URL: https://github.com/apache/camel/pull/28195#discussion_r4331012727
##########
components/camel-ftp-common/src/main/java/org/apache/camel/component/file/remote/RemoteFileConsumer.java:
##########
@@ -253,11 +255,47 @@ protected void forceDisconnect() {
}
}
+ /**
+ * Whether to send a noop before each poll to check that the connection is
still valid (the sendNoop option).
Review Comment:
💡 **Minor nit:** The Javadoc describes the primary behavior but doesn't
mention the deferred-noop path: even when this returns `false`, a noop will
still be sent on the next poll if a prior I/O failure set `sendNoopOnNextPoll`.
The `sendNoopOnNextPollIfIOFailure()` Javadoc explains this, but a reader of
`isSendNoop()` in isolation might miss it.
```suggestion
* Whether to send a noop before each poll to check that the connection
is still valid (the sendNoop option).
* Note: even when this returns false, a noop may be sent on the next
poll after an I/O failure
* (see {@link #sendNoopOnNextPollIfIOFailure}).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
