tyskjohan commented on PR #28195: URL: https://github.com/apache/camel/pull/28195#issuecomment-6312596340
Thanks for the reviews that came in after the merge. They are followed up here: - @allthingssecurity: confirmed. With the default `stepwise=true`, the first command of the next poll is the `PWD` in `pollDirectory()`. It fails outside the `try` in `getFtpFiles()` that sets the flag, so only `RemoteFilePollingConsumerPollStrategy` recovered. #28232 ([CAMEL-25915](https://issues.apache.org/jira/browse/CAMEL-25915)) does what you suggested: `RemoteFileConsumer.poll(Exchange)` calls `sendNoopOnNextPollIfIOFailure(e)` before it rethrows. Your reproducer is in `FtpConsumerSendNoopFalseIT`. - @oscerd: agreed, "found as it is today" holds only for JSch. #28232 adds your sentence to the upgrade guide and the `setSendNoop` Javadoc, with the pointer to `serverAliveInterval`. - @davsclaus: the NOOP before a rename or delete is [CAMEL-25916](https://issues.apache.org/jira/browse/CAMEL-25916). It describes the trade-off: without that NOOP, a rename after a long-running route can fail, and the file is then processed again. _Claude Code on behalf of tyskjohan_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
