allthingssecurity commented on PR #28200: URL: https://github.com/apache/camel/pull/28200#issuecomment-6310381396
On the bot's point: agreed, and fixed in 041a9ca4a3c9. When the lookup throws, the mail is not marked, and the key that `isValidMessage` added stayed in the repository, so the mail would be skipped as a duplicate. The catch path now settles the key with `commitIdempotentKey`, as the `found == null` path does. With the default `idempotentRepositoryRemoveOnCommit=true` the key is removed and a later poll consumes the unmarked mail again. With `false` the key is kept as configured. New test `idempotentKeyOfAMailThatCannotBeLookedUpAgainIsSettled` fails without the change. Side note: `processCommit`'s own `MessagingException` catch on main also leaves the key unsettled when marking fails. That predates this PR and I left it alone here. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
