allthingssecurity commented on PR #28262: URL: https://github.com/apache/camel/pull/28262#issuecomment-6330668231
On the bot's point about `XmppConsumer.checkConnection()`: the consumer side is in #28263 (CAMEL-25842), which changes exactly those lines. There, `checkConnection()` catches `AlreadyConnectedException` on its own (DEBUG, no misleading WARN), and also logs in again and re-enters the room, which a bare reconnect does not do. Changing the same lines here as well would make the two PRs conflict. Once both are in, I'll do one small follow-up that moves the consumer onto `endpoint.reconnect(connection)` too, so the consumers and producers of an account reconnect under the same lock. The same follow-up will make the producers log in again after a reconnect (they call only `connect()` today, also on main), using the `login()` helper that #28263 adds. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
