seshuthota commented on code in PR #28301: URL: https://github.com/apache/camel/pull/28301#discussion_r4351730231
########## core/camel-core/src/test/java/org/apache/camel/processor/UnmarshalAllowNullBodyTest.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.processor; + +import java.io.InputStream; +import java.io.OutputStream; +import java.nio.charset.StandardCharsets; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.Exchange; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.spi.DataFormat; +import org.apache.camel.support.service.ServiceSupport; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; + +public class UnmarshalAllowNullBodyTest extends ContextTestSupport { + + @Test + public void testAllowNullBodySkipsTheUnmarshalling() { + Object out = template.requestBodyAndHeader("direct:allow", null, "foo", "bar"); + assertNull(out); + } + + @Test Review Comment: Thanks! Right, it can't catch the dropped headers: the old code also returned a null body. It guards the skip itself, though: if allowNullBody stops skipping the data format, the null body reaches MyHelloDataFormat and the test fails with an exception (checked by disabling the skip). testAllowNullBodyKeepsHeaders covers the headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
