gnodet-bot commented on code in PR #28329:
URL: https://github.com/apache/camel/pull/28329#discussion_r4356796158
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/PQCProducer.java:
##########
@@ -155,15 +166,12 @@ protected void doStart() throws Exception {
}
Review Comment:
⚠️ **Inconsistent exception declaration vs. sibling `verification()`**
`signature()` now declares `throws Exception` (broad), while
`verification()` just below it retains the specific list:
`InvalidPayloadException, InvalidKeyException, SignatureException, IOException,
NoSuchAlgorithmException, NoSuchProviderException`. Both methods have identical
structure — they call `signerForExchange()` and `updateSignatureFromBody()`,
which throw the same exceptions. The `throws Exception` is likely a cherry-pick
artifact from `main` (where `signature()` gained
`checkStatefulKeyBeforeSign()`/`persistStatefulKeyStateAfterSign()` that do
throw broadly), but those calls are absent here.
```suggestion
throws InvalidPayloadException, InvalidKeyException,
SignatureException, IOException,
NoSuchAlgorithmException, NoSuchProviderException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
