gnodet-bot commented on code in PR #28329:
URL: https://github.com/apache/camel/pull/28329#discussion_r4357721260
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/PQCProducer.java:
##########
@@ -155,15 +166,12 @@ protected void doStart() throws Exception {
}
private void signature(Exchange exchange)
- throws InvalidPayloadException, InvalidKeyException,
SignatureException, NoSuchAlgorithmException,
- NoSuchProviderException {
- String payload = exchange.getMessage().getMandatoryBody(String.class);
-
+ throws Exception {
Review Comment:
⚠️ **`throws Exception` is unnecessarily broad here.** `verification()`
calls the same methods (`signerForExchange()`, `updateSignatureFromBody`,
`initVerify`/`verify`) and uses a precise throws clause — this looks like a
cherry-pick artifact where `main` may have additional callers that justify the
broad clause, but they're absent in this backport.
Narrow to match `verification()`:
```suggestion
throws InvalidPayloadException, InvalidKeyException,
SignatureException, IOException,
NoSuchAlgorithmException, NoSuchProviderException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
