gnodet-bot commented on code in PR #28385:
URL: https://github.com/apache/camel/pull/28385#discussion_r4365269553


##########
components/camel-pulsar/src/test/resources/log4j2.properties:
##########
@@ -15,14 +15,20 @@
 ## limitations under the License.
 ## ---------------------------------------------------------------------------
 
-appender.file.type = File
+appender.file.type = RollingFile
 appender.file.name = file
 appender.file.fileName = target/camel-pulsar-test.log
+appender.file.filePattern = target/camel-pulsar-test.%i.log
+appender.file.policies.type = Policies
+appender.file.policies.size.type = SizeBasedTriggeringPolicy
+appender.file.policies.size.size = 50MB
+appender.file.strategy.type = DefaultRolloverStrategy
+appender.file.strategy.max = 1
 appender.file.layout.type = PatternLayout
 appender.file.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
 appender.out.type = Console
 appender.out.name = out
 appender.out.layout.type = PatternLayout
 appender.out.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
-rootLogger.level = INFO
+rootLogger.level = WARN

Review Comment:
   ⚠️ **Side-effect:** This `rootLogger.level` change from `INFO` to `WARN` 
applies to the entire `camel-pulsar` test module, not just the new DST test. 
Any existing tests that rely on `INFO`-level log output (e.g. assertions on log 
messages, or tests that debug via log inspection) will silently stop seeing 
those logs. If the intent is to reduce noise only in the DST tests, consider a 
scoped logger override there instead of changing the root level for all tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to