allthingssecurity commented on code in PR #28385:
URL: https://github.com/apache/camel/pull/28385#discussion_r4366110220
##########
components/camel-pulsar/src/test/resources/log4j2.properties:
##########
@@ -15,14 +15,20 @@
## limitations under the License.
## ---------------------------------------------------------------------------
-appender.file.type = File
+appender.file.type = RollingFile
appender.file.name = file
appender.file.fileName = target/camel-pulsar-test.log
+appender.file.filePattern = target/camel-pulsar-test.%i.log
+appender.file.policies.type = Policies
+appender.file.policies.size.type = SizeBasedTriggeringPolicy
+appender.file.policies.size.size = 50MB
+appender.file.strategy.type = DefaultRolloverStrategy
+appender.file.strategy.max = 1
appender.file.layout.type = PatternLayout
appender.file.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
appender.out.type = Console
appender.out.name = out
appender.out.layout.type = PatternLayout
appender.out.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
-rootLogger.level = INFO
+rootLogger.level = WARN
Review Comment:
No test in camel-pulsar asserts on log output (none reads the log file or
adds an appender), so nothing depends on the INFO lines. The level and the 50
MB rolling file are there because the DST runs many seeds, each starting and
stopping routes and the fake broker, and at INFO the single test log grew to
several GB. If you prefer, I can keep the root at INFO and lower only the Camel
and Pulsar categories the DST floods.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
